@with directive fails to eager-load multiple nested relations on the same parent relation

[cradigan]

I've come across what i think is a bug involving the use of multiple @with directives

Here is an example schema:

type User{
   viewerSummary: ViewerSummary
     @with(relation: "shows.producers")
     @with(relation: "shows.actors")
     @with(relation: "films.producers")
     @with(relation: "films.actors")
     @method(name: "getViewerSummary")
}

In the given example, after loading a user with viewerSummary, actors are eager-loaded but producers are not.

Expected behavior/Solution

I would expect both relationships (producers & actors) to be eager loaded

Lighthouse Version

v5.63

[spawnia]

This issue was uncovered in #1915 and has not been fixed yet, see

lighthouse/tests/Integration/Schema/Directives/WithDirectiveTest.php

Lines 306 to 308 in 26c25e9

	public function testEagerLoadsMultipleNestedRelationsAtOnce(): void
	{
	$this->markTestSkipped('Not working due to the current naive usage of \Illuminate\Database\Eloquent\Collection::load() in \Nuwave\Lighthouse\Execution\ModelsLoader\SimpleModelsLoader::load().');

.

#1873 is related, it is probably a good idea to work on both issues at once.

[spawnia]

Duplicate of #1132.