Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about last modules #402

Open
Geminii opened this issue Feb 3, 2021 · 3 comments
Open

Discussion about last modules #402

Geminii opened this issue Feb 3, 2021 · 3 comments

Comments

@Geminii
Copy link
Contributor

Geminii commented Feb 3, 2021

What we need to do for the last packages of this repository, extract or delete ?

  • browserconfig
  • localtunnel
  • plugin-utils
  • vendor
  • toast => maybe delete this module

I'm waiting your suggestion about it @pi0 @Atinux

@pi0
Copy link
Member

pi0 commented Feb 3, 2021

Hi @Geminii

  • browserconfig => This can be deprecated
  • plugin-utils => This can be deprecated
  • localtunnel => we have ngrok module but it is half closed source compared to local tunnel
  • vendor => Fun to know it is doing vite idea by exposing node_modules to browser but needs a major rethinking
  • toast => Is there an alternative?

For localtunnel and vendor we need a home to keep (also toast i guess if there is no alternative). But this new hope finding is not periority honestly since i want to properly do rework for them but now so busy for ecosystem and nuxt3

@Geminii
Copy link
Contributor Author

Geminii commented Feb 3, 2021

Can i purpose a PR to remove deprecated module ?

For toast, there is some library for toast notification and i don't think there is a utility to create a module for it, what do you think about it ?

For localtunnel and vendor, we can simply extract it (for the moment) to separate them individually or do you want to keep it in this repository ?

Copy link
Member

Atinux commented Feb 6, 2021

I think you can make a PR for deprecated packages at first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants