Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nuxt-community/pwa-module
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.0-beta.18
Choose a base ref
...
head repository: nuxt-community/pwa-module
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.0-beta.19
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Sep 11, 2019

  1. Copy the full SHA
    c325e44 View commit details
  2. fix typo

    pi0 committed Sep 11, 2019
    Copy the full SHA
    cd0326e View commit details
  3. fix: truncate manifest hash

    teporary fix until we remove hash :)
    pi0 committed Sep 11, 2019
    Copy the full SHA
    5c74621 View commit details
  4. chore(release): 3.0.0-beta.19

    pi0 committed Sep 11, 2019
    Copy the full SHA
    ea55498 View commit details
Showing with 12 additions and 3 deletions.
  1. +8 −0 CHANGELOG.md
  2. +1 −1 lib/manifest/module.js
  3. +2 −1 lib/module.js
  4. +1 −1 package.json
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,14 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [3.0.0-beta.19](https://github.com/nuxt-community/pwa-module/compare/v3.0.0-beta.18...v3.0.0-beta.19) (2019-09-11)


### Bug Fixes

* expose modified pwa context to the config ([c325e44](https://github.com/nuxt-community/pwa-module/commit/c325e44))
* truncate manifest hash ([5c74621](https://github.com/nuxt-community/pwa-module/commit/5c74621))

## [3.0.0-beta.18](https://github.com/nuxt-community/pwa-module/compare/v3.0.0-beta.17...v3.0.0-beta.18) (2019-09-09)


2 changes: 1 addition & 1 deletion lib/manifest/module.js
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ function addManifest (pwa) {

// Stringify manifest & generate hash
const manifestSource = JSON.stringify(manifest)
const manifestFileName = `manifest.${hash(manifestSource)}.json`
const manifestFileName = `manifest.${hash(manifestSource).substr(0, 8)}.json`

// Merge final manifest into options.manifest for other modules
if (!this.options.manifest) {
3 changes: 2 additions & 1 deletion lib/module.js
Original file line number Diff line number Diff line change
@@ -2,7 +2,8 @@ module.exports = async function nuxtPWA (moduleOptions) {
const modules = ['icon', 'manifest', 'meta', 'workbox']

// Shared options context
const pwa = { ...this.options.pwa, ...moduleOptions }
this.options.pwa = { ...(this.options.pwa || {}), ...(moduleOptions || {}) }
const { pwa } = this.options

// Normalize options
for (const name of modules) {
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nuxtjs/pwa",
"version": "3.0.0-beta.18",
"version": "3.0.0-beta.19",
"description": "Supercharge Nuxt with a heavily tested, updated, zero-config and stable PWA solution!",
"repository": "nuxt-community/pwa-module",
"files": [