Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Router Base #88

Closed
mojtaba06 opened this issue Oct 30, 2019 · 4 comments
Closed

Consider Router Base #88

mojtaba06 opened this issue Oct 30, 2019 · 4 comments

Comments

@mojtaba06
Copy link

mojtaba06 commented Oct 30, 2019

What problem does this feature solve?

If defined the router base in nuxt.config.js file, the links in the sitemap file did not consider that.
router: {
base: '/something/'
}

What does the proposed changes look like?

When creating the links in the sitemap file, It would be nice that consider the router base to make the real link.

This feature request is available on Nuxt community (#c72)
@ghost ghost added the cmty:feature-request label Oct 30, 2019
@NicoPennec
Copy link
Member

Good catch!
It's a very old bug 😱
Thanks for your report @mojtaba06 🙏

I will fix it ASAP.

@mojtaba06
Copy link
Author

@NicoPennec Your welcome. Thanks for your attention and also for the useful module you wrote.

NicoPennec added a commit that referenced this issue Nov 7, 2019
NicoPennec added a commit that referenced this issue Nov 7, 2019
NicoPennec added a commit that referenced this issue Nov 7, 2019
NicoPennec added a commit that referenced this issue Nov 12, 2019
@NicoPennec
Copy link
Member

Issue fixed on release v2.0.1

@mareestephan
Copy link

mareestephan commented Oct 9, 2020

Is there an option to remove the router: {
base: '/something/'
}

when the sitemap links are generated?
eg. example.com/something/dynamicRoute/dynamicRoute/
it would be great to change /something/ to a string relating to the dynamic route selected.

Example below: Would like to change /juno/ to /ssi/
Screen Shot 2020-10-09 at 15 50 36
Screen Shot 2020-10-09 at 15 49 43
Screen Shot 2020-10-09 at 15 49 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants