Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Support chromatic's --webpack-stats-json flag #367

Merged
merged 1 commit into from
Feb 21, 2022
Merged

feat(cli): Support chromatic's --webpack-stats-json flag #367

merged 1 commit into from
Feb 21, 2022

Conversation

valernyx
Copy link

Adds support for the --webpack-stats-json flag so Chromatic can pass it through successfully and Nuxt Storybook can be used to publish to Chromatic with TurboSnap enabled.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Chromatic, a cloud-based tool used to publish Storybook instances and facilitate UI review, has a feature called TurboSnap which allows smart snapshotting for visual regression testing. When publishing Storybook using the Chromatic CLI and the --only-changed flag to activate TurboSnap, it calls build-storybook and attempts to pass the --webpack-stats-json flag automatically, which causes the command to fail and prevents using TurboSnap with Nuxt Storybook.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@farnabaz farnabaz changed the title feat(cli): Support Chromatic's --webpack-stats-json flag feat(cli): Support chromatic's --webpack-stats-json flag Feb 21, 2022
@farnabaz farnabaz merged commit 56c8eef into nuxt-modules:master Feb 21, 2022
@farnabaz farnabaz mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants