Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.6 has problems with uppercase alias names #125

Closed
toniengelhardt opened this issue Nov 23, 2023 · 5 comments
Closed

v0.6.6 has problems with uppercase alias names #125

toniengelhardt opened this issue Nov 23, 2023 · 5 comments

Comments

@toniengelhardt
Copy link
Contributor

In v0.6.5 this works:

nuxtIcon: {
  aliases: {
    'aws': 'IconAWS',
    // ...
  }
}

if there is a component in global named IconAWS.vue, but in v0.6.6 it breaks. The reason is the uppercase naming, if I rename the component and the alias to IconAws.vue it works.

Copy link
Contributor

Atinux commented Nov 23, 2023

Might be related to nuxt/nuxt#24318

Could you confirm with the latest Nuxt version?

@toniengelhardt
Copy link
Contributor Author

toniengelhardt commented Nov 23, 2023

@Atinux not sure what's going on, just tested with nuxt@3.8.0...3.8.2 and nuxt-icon@0.6.1...0.6.6 and it's broken with all of those. But I'm pretty sure it worked and I just realized that it is broken a few days ago. And there is no reason why uppercase names should not work right?

Copy link
Contributor

Atinux commented Nov 29, 2023

Damn, I suspect it comes from scule update that transform IconAWS to IconAws.

Could you check with latest Nuxt version and look at the devtools to see your components names?

@toniengelhardt
Copy link
Contributor Author

Sorry for the delay @Atinux, got taken down by the flu...

I'm not sure what exactly changed, but it seems to be working now.

Closing 🙏🏽

@toniengelhardt
Copy link
Contributor Author

toniengelhardt commented Dec 24, 2023

@Atinux I found the problem. Turns out for some reason my git was set up to ignore case and the changes were not properly tracked on GitHub. That's why it worked locally and not in production.

Everything seems to work properly now.

If someone finds this, the solution was to update the git settings like

> git config core.ignorecase false

and then commit the file name changes properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants