Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plugin types are exposed #31

Closed
johannschopplich opened this issue Aug 6, 2024 · 0 comments
Closed

Ensure plugin types are exposed #31

johannschopplich opened this issue Aug 6, 2024 · 0 comments

Comments

@johannschopplich
Copy link
Collaborator

          This did not fix the problem. I tried updating the module to v1.0.1 and replacing `trackLocalhost` with `ignoredHostnames`, and all of the analytics e2e tests failed, see [this CI run](https://github.com/WordPress/openverse/actions/runs/10250122171/job/28355208871?pr=4716). When I added `trackLocalhost` back, they [passed](https://github.com/WordPress/openverse/actions/runs/10260245561/job/28386045331?pr=4716).

After updating, the plugin types also broke: I had to manually add the types that were previously created by Nuxt automatically. This might be related to the "The inferred type of 'default' cannot be named without a reference to ..." warnings in the release action run for v1.0.1: https://github.com/nuxt-modules/plausible/actions/runs/10229250370
Would using a function for module defaults fix it?

Originally posted by @obulat in #30 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant