Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create dummy package.json for ESM compatibility #345

Merged
merged 3 commits into from Nov 29, 2021

Conversation

tobiasdiez
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

If you have type: module in your main package.json, then storybook doesn't work. This is not an issue with the nuxt module, but with upstream storybook, see storybookjs/storybook#11587.
In this issue, a workaround is outlined which involves creating a package.json in the storybook folder.
This is added with this PR.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@tobiasdiez tobiasdiez mentioned this pull request Nov 17, 2021
38 tasks
@farnabaz farnabaz changed the title Add package.json for esm compatibility fix: create dummy package.json for ESM compatibility Nov 24, 2021
src/index.ts Show resolved Hide resolved
@farnabaz farnabaz merged commit 7915f30 into nuxt-modules:master Nov 29, 2021
@tobiasdiez tobiasdiez deleted the patch-2 branch November 29, 2021 09:11
@farnabaz farnabaz mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants