Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined render args argument #378

Merged
merged 1 commit into from Apr 26, 2022

Conversation

adesombergh
Copy link

@adesombergh adesombergh commented Apr 4, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Since version 4.3.0, args/controls don't work (#373). That's because the argument passed to the render function does not have any args object passed to it (it's always undefined). The args are now available in the storyContext object that is passed to the render function.
This is already used in storybook's latest vue render function

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@hacknug
Copy link

hacknug commented Apr 26, 2022

@farnabaz anything we can do to help get this merged?

@farnabaz
Copy link
Collaborator

Thank you ❤️

@hacknug I'm going to release a new version today

@farnabaz farnabaz changed the title fix: fixed undefined render args argument (#373) fix: undefined render args argument Apr 26, 2022
@farnabaz farnabaz merged commit ba614fd into nuxt-modules:master Apr 26, 2022
This was referenced Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants