Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep NODE_ENV set by users #383

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

GMartigny
Copy link

Don't override the NODE_ENV if it's already set.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When runnnig storybook, I need to use special setting in my nuxt.config.js. I tried to set NODE_ENV to any value (storybook for example), but the module would always override it.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

I think this should be the default behavior and would not require test or documentation.

@farnabaz farnabaz changed the title Keep NODE_ENV set by users fix: keep NODE_ENV set by users Apr 26, 2022
@farnabaz
Copy link
Collaborator

Thanks ❤️

@farnabaz farnabaz merged commit 21064f4 into nuxt-modules:master Apr 26, 2022
@farnabaz farnabaz mentioned this pull request Apr 26, 2022
@GMartigny GMartigny deleted the patch-1 branch April 26, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants