Implement PostCSS support #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K3TH3R
commented
Jul 2, 2020
| @@ -92,5 +96,6 @@ const extendWithSassResourcesLoader = matchRegex => resources => (config) => { | |||
| const extendSass = extendWithSassResourcesLoader(/sass/) | |||
| const extendScss = extendWithSassResourcesLoader(/scss/) | |||
| const extendLess = extendWithSassResourcesLoader(/less/) | |||
| const extendPostCSS = extendWithSassResourcesLoader(/\?css/) | |||
There was a problem hiding this comment.
Nuxt uses a loader test that looks like this: /\.p(ost)?css$/i, so I test for the ?css portion to match this loader test, but ignore .css and .scss loaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@manniL this is a PR to implement the necessary changes to close #18. I was unable to get the repo's test environment working on my computer, so I can't guarantee the tests are currently passing. However, I made the changes originally to the
style-resources-moduledirectly in mynode_modulesdirectly for my Nuxt.js project and everything was working properly so I just moved those changes over for this PR.