Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windi CSS (no longer required) #264

Closed
alexcroox opened this issue Feb 16, 2021 · 15 comments
Closed

Windi CSS (no longer required) #264

alexcroox opened this issue Feb 16, 2021 · 15 comments
Labels
enhancement New feature or request

Comments

@alexcroox
Copy link

alexcroox commented Feb 16, 2021

https://windicss.netlify.app/

For your consideration. Supposedly it drastically improves dev start up times which is a common problem when using Tailwind.

https://twitter.com/antfu7/status/1361398324587163648

Edit: this may no longer be required due to improvements in core tailwind: #264 (comment)

@alexcroox alexcroox added the enhancement New feature or request label Feb 16, 2021
Copy link
Collaborator

Atinux commented Feb 16, 2021

Thanks for creating the issue, we are already testing it and see how we can integrate it properly.

Copy link
Collaborator

Atinux commented Feb 16, 2021

Any help is more than welcome 💚

@alexcroox
Copy link
Author

Further discussion here: #203

@ram-you
Copy link

ram-you commented Feb 17, 2021

Any help is more than welcome

@antfu can you help please ?

@harlan-zw
Copy link
Contributor

Happy to take a look at this.

Any notes on implementation? Should we expect users to do the migration steps themselves? https://windicss.netlify.app/guide/migration.html#base-styles

@alexcroox
Copy link
Author

alexcroox commented Feb 17, 2021

Don't know if it helps but I'm also tracking nuxt-build-optimisations repo who are also looking to implement it automatically so there might be some pointers:

https://github.com/loonpwn/nuxt-build-optimisations/tree/feat/windycss

https://github.com/loonpwn/nuxt-build-optimisations/commits/feat/windycss

@alexcroox
Copy link
Author

oh :fail: I just noticed you are the author of that repo @loonpwn 😅

@harlan-zw
Copy link
Contributor

oh :fail: I just noticed you are the author of that repo @loonpwn

Haha good to know someone is watching 👀

Update for you @Atinux:

To implement this using the loader vue-windicss-preprocess is pretty much there. The missing pieces are: the loader doesn't support passing the config in as an object (breaking hooks), which I have sent a PR for and updating the documentation site.

I am a little bit concerned with this issue windicss/vue-windicss-preprocess#3. If the base loader has some bugs with vendor packages then it may trip up some users. Will need some more testing.

Code is here: harlan-zw@0670b97

Copy link
Collaborator

Atinux commented Feb 18, 2021

Thank you so much for looking at it and making progress @loonpwn

I will take a look as soon as I am done recording my talk for Nuxt 3 for VueJS Amsterdam.

@viennv1709
Copy link

@Atinux Could you publish the roadmap for Nuxt3? I can't wait to know when it's released

@Mikaleb
Copy link

Mikaleb commented Feb 19, 2021

@viennv1709 I think we'll get all details after the VueJS Amsterdam talks. You can follow it live next week though, I sure will !

@alexcroox
Copy link
Author

alexcroox commented Mar 1, 2021

This may not be required anymore, Adam seems to be working on vastly improving Tailwind HMR/build times in the core of tailwind:

image

https://twitter.com/adamwathan/status/1364270507361730563

https://twitter.com/adamwathan/status/1366492530569850880

https://twitter.com/adamwathan/status/1366509825186795524

@alexcroox alexcroox changed the title Windi CSS Windi CSS (no longer required) Mar 1, 2021
Copy link
Collaborator

Atinux commented Mar 2, 2021

Indeed, I am already testing with it (private at the moment) and we see perfs improvements 😄

@harlan-zw
Copy link
Contributor

Windicss implementation will released as a seperate package. This can probably be closed.

@alexcroox
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants