Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow rel for socials links to be configured #899

Merged
merged 4 commits into from May 16, 2023

Conversation

Barbapapazes
Copy link
Contributor

@Barbapapazes Barbapapazes commented Apr 28, 2023

fix #898

This PR follow #889

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 28, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Docus Edit on Studio ↗︎ View Live Preview 548ccd3

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docus ✅ Ready (Inspect) Visit Preview May 16, 2023 3:59pm

@Barbapapazes Barbapapazes changed the title fix: allow rel for socials links to be configured feat: allow rel for socials links to be configured Apr 28, 2023
@Atinux
Copy link
Contributor

Atinux commented May 4, 2023

Could you also add it to

docus/nuxt.schema.ts

Lines 235 to 242 in 866cf46

properties: {
icon: { type: 'string', description: 'Icon name' },
href: {
type: 'string',
description: 'Link when clicking on the icon'
},
label: { type: 'string', description: 'Label of the icon' }
}
as well?
I guess we need to also add the textLinks too

@Tahul Tahul merged commit fbd0971 into nuxt-themes:main May 16, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow rel in socials links to be configured
3 participants