Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consola): use options.stderr #77

Merged
merged 1 commit into from Dec 17, 2019
Merged

fix(consola): use options.stderr #77

merged 1 commit into from Dec 17, 2019

Conversation

tjeeay
Copy link
Contributor

@tjeeay tjeeay commented Nov 20, 2019

No description provided.

@hobroker
Copy link

hobroker commented Nov 22, 2019

This is a pretty big bug. How wasn't this noticed before?

Actually this is the intended behaviour.

@pi0
Copy link
Member

pi0 commented Nov 24, 2019

I think it was simply a typo. @hobroker any points keeping it as is now?

@hobroker
Copy link

@pi0, I might be wrong, I don't understand how it's stderr is used in the code. Sorry 🙂

@pi0
Copy link
Member

pi0 commented Nov 24, 2019

in both cases (typo or not inline comment) blames are towards me :D I'll ensure it before merge/close.

@pi0 pi0 changed the title fix a typo. fix(consola): use options.stderr Dec 17, 2019
@pi0 pi0 merged commit 774c673 into unjs:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants