Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): expose MarkdownParsedContent for improved type generics #1199

Merged
merged 4 commits into from Jun 3, 2022

Conversation

harlan-zw
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add a Markdown specific parsed content schema, allowing end-users to build generics that have better type safety.

I did see #1057, I'd presume we'd need a safer type for markdown files when that's built so this should help with that.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 2, 2022

‼️ Deploy request for nuxt-content rejected.

Name Link
πŸ”¨ Latest commit 7ccec6e

@harlan-zw harlan-zw changed the title feat(types): expose MarkdownParsedContent for improved markdown type generics feat(types): expose MarkdownParsedContent for improved type generics Jun 2, 2022
@Tahul
Copy link
Contributor

Tahul commented Jun 3, 2022

This is an excellent first step towards #1057 ; would love to include you in the loop about this type generation feature!

Thank you a lot @harlan-zw πŸ˜„

@Tahul Tahul merged commit 0329ac9 into nuxt:main Jun 3, 2022
@harlan-zw
Copy link
Contributor Author

Yes please do @Tahul, I was thinking about how this could be achieved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants