Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): provide augmentations for only and without #1200

Merged
merged 3 commits into from Jun 3, 2022
Merged

feat(types): provide augmentations for only and without #1200

merged 3 commits into from Jun 3, 2022

Conversation

harlan-zw
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allows type hinting on the keys for only and without as well as augmenting the result which will either include or exclude the provided keys from the IntelliSense respectively.

image

image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 2, 2022 •
edited

✅ Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit cace6d4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/629a020ec201ae000836fb92
😎 Deploy Preview https://deploy-preview-1200--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Atinux
Atinux approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Awesome change. Maybe @farnabaz can have a second review

@Atinux Atinux requested a review from farnabaz June 3, 2022 12:13
farnabaz
farnabaz approved these changes Jun 3, 2022
View reviewed changes
src/runtime/query/query.ts Outdated Show resolved Hide resolved
src/runtime/query/query.ts Outdated Show resolved Hide resolved
@Tahul @farnabaz
Apply suggestions from code review
cace6d4 
Co-authored-by: Ahad Birang <farnabaz@gmail.com>
@Tahul Tahul merged commit 51a1620 into nuxt:main Jun 3, 2022
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz added a commit that referenced this pull request Sep 7, 2022
@harlan-zw @farnabaz @Tahul
feat(types): provide augmentations for only and without (#1200)
f6130d2 
Co-authored-by: Ahad Birang <farnabaz@gmail.com>
Co-authored-by: Yaël Guilloux <yael.guilloux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atinux Atinux Atinux approved these changes

@Tahul Tahul Tahul approved these changes

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harlan-zw @Atinux @Tahul @farnabaz