Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): support multiple themes for code highlighter #1251

Merged
merged 4 commits into from Jun 14, 2022

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Jun 13, 2022

πŸ”— Linked issue

resolves #1135

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

// nuxt.config
{
  content: {
    highlight: {
      theme: {
        default: 'github-light',
        dark: 'github-dark'
      }
    }
  }
}

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 13, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit cacc7e0
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62a869355e3ab500083fdc1b
😎 Deploy Preview https://deploy-preview-1251--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz marked this pull request as ready for review June 14, 2022 09:43
@farnabaz farnabaz requested a review from Tahul June 14, 2022 09:44
Copy link
Contributor

@Tahul Tahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

I've added documentation for the feature, could you review it then merge the PR @farnabaz ? πŸ˜„

@farnabaz
Copy link
Member Author

@Tahul LGTM πŸ‘

@Tahul Tahul merged commit cd80cf8 into main Jun 14, 2022
@Tahul Tahul deleted the feat/shiki-multi-theme branch June 14, 2022 13:42
@vinayakkulkarni
Copy link
Contributor

Can this be done in v2.0.2 or a new release?

@farnabaz
Copy link
Member Author

farnabaz commented Jul 4, 2022

@vinayakkulkarni you can use this feature by using the edge version. See https://content.nuxtjs.org/guide/migration/edge-channel

@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: YaΓ«l Guilloux <yael.guilloux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark/Light code highlight themes
3 participants