Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support navigation field in content and _dir.yml #1328

Merged
merged 10 commits into from Jul 5, 2022

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Jul 3, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds support for a navigation field in both pages and _dir.yml to overwrite the data. This also remove the extra step to add keys into navigation.fields in the nuxt.config.

---
navigation.title: 'Home'
---

# Another title

Also, it fixes a bug where the title and description are not discovered with empty front-matter:

---
---

# Title not detected

Description not detected as well

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 3, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit f9d8270
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62c413ee7a1aac0009a99742
😎 Deploy Preview https://deploy-preview-1328--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz requested a review from Tahul July 4, 2022 15:05
@Atinux Atinux merged commit 4267bf2 into main Jul 5, 2022
@Atinux Atinux deleted the feat/navigation-field branch July 5, 2022 11:00
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Ahad Birang <farnabaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants