Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document-driven): add empty promise for disabled features #1356

Merged
merged 1 commit into from Jul 14, 2022

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Disabling page or navigation in document-driven will cause reducing promises length and therefore leads to invalid behavior.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@farnabaz farnabaz marked this pull request as ready for review July 14, 2022 12:20
@netlify
Copy link

netlify bot commented Jul 14, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit da827f0
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62d009fb52992d0008e773c0
😎 Deploy Preview https://deploy-preview-1356--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Atinux Atinux merged commit 9582f8c into main Jul 14, 2022
@Atinux Atinux deleted the fix/document-driven-promises branch July 14, 2022 12:38
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants