Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve where query types #1359

Merged
merged 3 commits into from Jul 19, 2022
Merged

feat: improve where query types #1359

merged 3 commits into from Jul 19, 2022

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Jul 18, 2022

πŸ”— Linked issue

resolves #1358

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Improve types of query builder. Add type for where conditions.

Screenshot 2022-07-18 at 14 46 13

Screenshot 2022-07-18 at 14 45 36

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 18, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 0cbe00c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62d6052245e0860008d69495
😎 Deploy Preview https://deploy-preview-1359--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Tahul
Copy link
Contributor

Tahul commented Jul 19, 2022

This looks amazing, I love it 😍

@Tahul
Copy link
Contributor

Tahul commented Jul 19, 2022

As you are opening a PR on types, I added a small commit, it should resolve #1358

I would love to get feedback on it, as I've tried it locally with yarn link and it seemed to have improved the situation for inference with Volar, but I guess we need multiple validations on this. πŸ˜…

@farnabaz farnabaz marked this pull request as ready for review July 19, 2022 08:49
@farnabaz
Copy link
Member Author

farnabaz commented Jul 19, 2022

I can confirm that renaming files to .vue improve the typings of components.

@Tahul Tahul merged commit 04f9dad into main Jul 19, 2022
@Tahul Tahul deleted the feat/query-typed-where branch July 19, 2022 15:02
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: YaΓ«l Guilloux <yael.guilloux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Components other type than any
3 participants