Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: documentDriven configuration #1378

Merged
merged 4 commits into from Jul 26, 2022
Merged

feat: documentDriven configuration #1378

merged 4 commits into from Jul 26, 2022

Conversation

farnabaz
Copy link
Member

🔗 Linked issue

resolves #1345

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

definePageMeta({
  documentDriven: {
    page: '/'
  }
})

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 25, 2022 •
edited

✅ Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit c1c224c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62de88809a0e330007e6dc22
😎 Deploy Preview https://deploy-preview-1378--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Tahul Tahul marked this pull request as ready for review July 25, 2022 11:00
@Atinux
Copy link
Member

Atinux commented Jul 25, 2022

Could we add also an example at the bottom of https://content.nuxtjs.org/guide/writing/document-driven as well?

Tahul
Tahul approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@Tahul Tahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent addition 😄

@farnabaz farnabaz merged commit 6cf2094 into main Jul 26, 2022
@farnabaz farnabaz deleted the feat/dd-config branch July 26, 2022 14:23
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz added a commit that referenced this pull request Sep 7, 2022
@farnabaz
feat: documentDriven configuration (#1378)
304a3af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tahul Tahul Tahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better documentDriven configuration
3 participants
@farnabaz @Atinux @Tahul