Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document-driven): Only set 404 status on SSR #1409

Merged
merged 4 commits into from Aug 2, 2022
Merged

fix(document-driven): Only set 404 status on SSR #1409

merged 4 commits into from Aug 2, 2022

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Aug 2, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It should not return a Nuxt error but only set the 404 status code on SSR, when using the dd mode, you can create a <DocumentDrivenNotFound /> component

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 2, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 6a160a8
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62e94114629865000951ebfc
😎 Deploy Preview https://deploy-preview-1409--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Atinux
Copy link
Member Author

Atinux commented Aug 2, 2022

Would like a second eye for the tests @farnabaz

@Atinux Atinux requested a review from farnabaz August 2, 2022 15:07
@Atinux Atinux merged commit 066c341 into main Aug 2, 2022
@Atinux Atinux deleted the fix/dd-404 branch August 2, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants