Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure components/content is on top in layers #1418

Merged
merged 1 commit into from Aug 8, 2022

Conversation

CodeDredd
Copy link
Contributor

πŸ”— Linked issue

closes #1417, related to nuxt/framework#6382

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In mutli layer setups the priority of the layers is wrong and needs to be reversed, so that content is on top

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 5, 2022

βœ… Deploy Preview for nuxt-content ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 5c57d96
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62ed6bcf33aef200096c8feb
😎 Deploy Preview https://deploy-preview-1418--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Atinux Atinux requested review from pi0 and farnabaz August 5, 2022 23:42
@pi0
Copy link
Member

pi0 commented Aug 7, 2022

Thanks for the PR @CodeDredd <3

As you mentioned in #1417 (comment), this doesn't fully resolve the behavior to close the issue but combined with nuxt/framework#6382 it should be. And in general I think change makes sense combining unshift with reverse layer scanning.

@farnabaz farnabaz merged commit 19bcce5 into nuxt:main Aug 8, 2022
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
@pi0 pi0 mentioned this pull request Aug 16, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot override components/content when using multi layer
3 participants