Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(<ContentRenderer>): prioritize default slot #1460

Merged
merged 2 commits into from Aug 17, 2022

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

resolves #1459

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Using the default slot in <ContentRenderer> did not affect rendered HTML when the content is a markdown file.
This PR will prioritize the empty slot and the default slot.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 17, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit d130849
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62fcce9e9f85a300083fc072
😎 Deploy Preview https://deploy-preview-1460--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz requested a review from Atinux August 17, 2022 10:58
@Atinux
Copy link
Member

Atinux commented Aug 17, 2022

Would you mind adding a test case?

@farnabaz farnabaz merged commit bf35a81 into main Aug 17, 2022
@farnabaz farnabaz deleted the fix/respect-default-slot branch August 17, 2022 13:42
@farnabaz farnabaz mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<ContentRenderer> default slot problem?
2 participants