Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken prev next from useContent, regression/breaking change #2338

Closed
Szymon-dziewonski opened this issue Sep 24, 2023 · 5 comments
Closed

Comments

@Szymon-dziewonski
Copy link

Szymon-dziewonski commented Sep 24, 2023

Environment

  • Operating System: Darwin
  • Node Version: v18.16.1
  • Nuxt Version: 3.7.3
  • CLI Version: 3.9.0
  • Nitro Version: 2.6.3
  • Package Manager: yarn@1.22.19
  • Builder: -
  • User Config: modules, content
  • Runtime Modules: @nuxt/content@2.8.2
  • Build Modules: -

Reproduction

In 2.7.2

c91f92d4-2525-4e10-b20b-323dd0a7c99c.webm

Repo with reproduction
https://github.com/Szymon-dziewonski/NuxtContentPrefetch/tree/broken-pre-next

In 2.8.2 its broken totally (next and prev method), around 2.7.4 starts breaking with prev method only coming from useContent

60747c95-3b82-4ae0-af35-842b4bcb4a47.webm

Repo with reproduction
https://github.com/Szymon-dziewonski/NuxtContentPrefetch/tree/broken-prev-next-2.8.2

Both run yarn and then yarn dev, check content structure and run http://localhost:3000/1/1.1 then play with it

Describe the bug

When having nested structure like so:
image

There is breaking change or regression after version 2.7.2 that causes prev and next methods coming from useContent not usable, pointing wrong next and previous links

Additional context

No response

Logs

No response

@Szymon-dziewonski Szymon-dziewonski changed the title Broken prev next from useContent, regression, breaking change Broken prev next from useContent, regression/breaking change Sep 24, 2023
@farnabaz
Copy link
Member

This should be fixed in edge channel. Do you mind checking edge channel and confirm the fix?

@Szymon-dziewonski
Copy link
Author

Hey @farnabaz seems like its fixed on edge channel indeed, so probably this ticket can be closed. Can you maybe point PR that fixes issue?

@nobkd
Copy link
Contributor

nobkd commented Sep 26, 2023

I think those are the related PRs:

@Szymon-dziewonski
Copy link
Author

@nobkd appreciate that :) Thanks

@farnabaz
Copy link
Member

Released in v2.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants