fix: ContentQuery _path not used properly (#1141)
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-content ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hello @GerryWilko 😄 I added a small comment to your PR, I was already working on the fix! If we can merge this branch, I can continue my work on tests for these components on mine. 🙂 Waiting for your feedback! |
Tahul
suggested changes
May 25, 2022
Tahul
changed the title
_path not used properly (#1141)
Tahul
approved these changes
May 25, 2022
|
Hi @Tahul yep that makes sense to me! I thought it was a bit odd that the path sanitizing was in multiple places so pushing into the existing content query makes sense to me. I was trying to accept your change but it looked like it was going accept it in a strange place unless I misunderstood the preview GitHub was showing me. I haven't used the suggested change feature myself so not very familiar with it 😄 Thanks for the approve! |
Tahul
changed the title
_path not used properly (#1141)_path not used properly (#1141)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1141
❓ Type of change
📚 Description
Content queries didn't seem to be working quite right when querying folders. If there was a matching exact file then it seemed to work ok but
ContentListandContentQuerythat were pointing at folders seemed to be broken.Looks like the intention was for the path was to match the start allowing a list of all child content pages to be returned.
📝 Checklist