Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open graph tab #209

Merged
merged 15 commits into from May 8, 2023
Merged

feat: add open graph tab #209

merged 15 commits into from May 8, 2023

Conversation

arashsheyda
Copy link
Member

@arashsheyda arashsheyda commented May 2, 2023

tried to help with #121

fix #121

Example Video
seo.mp4

Copy link
Member

Atinux commented May 2, 2023

This is amazing!

@arashsheyda
Copy link
Member Author

arashsheyda commented May 2, 2023

@Atinux thanks :D, it needs review though I think

@antfu
Copy link
Member

antfu commented May 2, 2023

@arashsheyda Thanks a lot for all the awesome contributions! It looks great, and I will review it ASAP!

@arashsheyda
Copy link
Member Author

@antfu thanks

@antfu
Copy link
Member

antfu commented May 2, 2023

@arashsheyda could you share your demo project? I think we could have multiple playgrounds for playing with different features. It's hard for one app to cover all the needs. (like I pushed for playgrounds/tab-seo, you can directly override it with your setup.) Thanks!

@arashsheyda
Copy link
Member Author

arashsheyda commented May 2, 2023

@antfu i edited some pages in playground(I hope i didn't do something wrong ,lol)

and I think there is a problem:

  • for og: and twitter: tags, it is getting them from property, some use name, I think, example:
    { name: 'og:title', content: 'title' },

  • if there is no twitter:card it should not show the preview(I'm not sure about this one but Social Share Preview does it this way)

thank you realy, it looks so much better this way 💯

@antfu antfu marked this pull request as draft May 3, 2023 14:51
@antfu
Copy link
Member

antfu commented May 3, 2023

Thanks! Actually, there would still be a lot of work to do to make it work better, like how it previews without og:image or different type of twitter:card etc. Marking it as draft and I will work on it slowly

@antfu antfu changed the title feat: experimental seo tab feat: add open graph tab May 8, 2023
@antfu antfu marked this pull request as ready for review May 8, 2023 12:25
@antfu
Copy link
Member

antfu commented May 8, 2023

Thanks a lot! Let's have it and iterates as we go!

@arashsheyda arashsheyda deleted the seo branch May 17, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEO Tab
3 participants