Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DockingPanel clickoutside on iframe #211

Merged
merged 1 commit into from May 3, 2023

Conversation

arashsheyda
Copy link
Member

click on iframe was not closing the DockingPanel component,
is this ok or should we go with something more like this?

<button
  i-logos-nuxt-icon my3 h-6 w-6 pb-2 text-lg
  :class="client ? '' : 'saturate-0'"
  :title="client ? 'Nuxt DevTools' : 'DevTools Client not connected, try open it in iframe mode'"
  @click="show = !show"
/>
<Teleport to="body">
  <div ref="panel" v-lazy-show="show" absolute left-15 top-2 z-100 border border-base rounded text-black shadow bg-base dark:text-white>
    <!-- needs to be triangle shape -->
    <div absolute left--2 top-3 h-2 w-2 border="l t b base" bg-base />
    <DockingPanel ml2 />
  </div>
</Teleport>

@antfu antfu merged commit afdaa5b into nuxt:main May 3, 2023
2 of 3 checks passed
@arashsheyda arashsheyda deleted the dockingpanel branch May 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants