Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split screen support #327

Merged
merged 10 commits into from
Jul 18, 2023
Merged

feat: split screen support #327

merged 10 commits into from
Jul 18, 2023

Conversation

arashsheyda
Copy link
Member

Split Screen Mode (ability to add a second page) resolves #182

13.07.2023_16.51.45_REC.mp4

@antfu
Copy link
Member

antfu commented Jul 13, 2023

Nice idea! I pushed some UI changes to the branch.

A few blockers we need to clear before merging this

  • Find a way to isolate the route state. Currently many tabs relies on route hash to preserve navigation state. In the splitscreen will also update the hash, which will conflicts with the main view
  • Improve some RWD for tabs on narrow width
  • Able to make them work for custom iframe view as well (related to route path as the first point)

@arashsheyda
Copy link
Member Author

@antfu thanks.

  • aw yes. should we use useState or something like that?
  • should I open a new PR for this?
  • I think we can solve the custom iframe with passing props, should I push this?
Home.page.-.Google.Chrome.2023-07-13.23-46-55.mp4

@antfu
Copy link
Member

antfu commented Jul 14, 2023

Yeah I think each tab needs to be able to work in hash mode and memory (useState sounds good), controlled by the parent view.

Please update directly in this PR.

And for iframe, yes that sounds good

@arashsheyda
Copy link
Member Author

I did refactore the hash & query to composable(state-rotues), I hope I didn't miss any
cc @antfu

@antfu antfu changed the title feat: split screen mode feat: split screen support Jul 18, 2023
@antfu antfu merged commit f2eee67 into nuxt:main Jul 18, 2023
1 of 3 checks passed
@arashsheyda arashsheyda deleted the feat/split-page branch July 18, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants