feat: install modules at once #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Jul 18, 2023
|
|
||
| addNuxtModule(mod, name) | ||
|
|
||
| const generated = mod.generate().code | ||
| latestGenerated = generated // cache the latest generated config |
There was a problem hiding this comment.
This needs to put in non-dry condition
| @@ -54,6 +54,9 @@ export function setupNpmRPC({ nuxt, ensureDevAuthToken }: NuxtDevtoolsServerCont | |||
| } | |||
| } | |||
|
|
|||
| const installQueue: string[] = [] | |||
There was a problem hiding this comment.
Yeah, it's been changed to Set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #331
Implemented an install queue: I added an installQueue where the module name is pushed into the queue when the module starts installing. When the module installation is complete, the module name is removed from the queue.
Only when all modules are installed is the new configuration written to the file. This prevents an automatic reboot when updating the config, which would result in only one module being installed.