fix: pinned tabs filter #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jannchie
commented
Jul 29, 2023
Jannchie
commented
- Fixed a bug that "pinned" catalog could not be hidden by switch.
- Fixed a bug that hiding the "app" catalog would also hide the "pinned" catalog.
antfu
reviewed
Jul 30, 2023
Comment on lines
98
to
99
| if (settings.pinnedTabs.value.includes(_tab.name)) | ||
| _tab.category = 'pinned' |
There was a problem hiding this comment.
I guess we should not mutate the object, and not do it in a .filter()
There was a problem hiding this comment.
Indeed, I will try to fix the problem without modifying the category.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.