Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assets): remove dot from file extension #512

Merged
merged 2 commits into from Nov 8, 2023

Conversation

arashsheyda
Copy link
Member

@arashsheyda arashsheyda commented Nov 8, 2023

. from ext was blocking defaultAllowedExtensions to gt upload.

sorry I forgot to add .slice(1) in the main PR #391

note: sometimes there are some small fixes(or mistakes like this), should I open PR or commit directly? \cc @antfu

@arashsheyda arashsheyda changed the title fix: remove dot from file extension fix(assets): remove dot from file extension Nov 8, 2023
Copy link

cloudflare-pages bot commented Nov 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2813f23
Status: ✅  Deploy successful!
Preview URL: https://6c2f1a2d.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-assets-file-extention-tr.nuxt-devtools.pages.dev

View logs

@antfu
Copy link
Member

antfu commented Nov 8, 2023

Thanks. It would be better to do PR like this so I can have a glance. You can merge them yourself later if CI passes and you believe it's non-controversial.

@arashsheyda
Copy link
Member Author

Ah yes, for sure! thanks

@antfu antfu merged commit 8e4ec7b into main Nov 8, 2023
3 checks passed
@antfu antfu deleted the fix/assets-file-extention-trim branch November 8, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants