Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation in Testing #1600

Open
LukasBombach opened this issue Sep 20, 2019 · 6 comments
Open

Improve Documentation in Testing #1600

LukasBombach opened this issue Sep 20, 2019 · 6 comments
Labels

Comments

@LukasBombach
Copy link

What problem does this feature solve?

For a lot of us proper testing is a big topic and it's hard to find documentation on how to test Nuxt-specific features. Currently I am trying to find out how to test asyncData and there is very little information on that on the internet and no information on the website. There is one example on how to run a test with AVA, but I feel testing should be a big part of software development and in the documentation.

What does the proposed changes look like?

Documentation on how to test a Nuxt app, specifically Nuxt-specific features.

This feature request is available on Nuxt community (#c9801)
@VladDubrovskis
Copy link

VladDubrovskis commented Sep 27, 2019

This is quite interesting problem. One way I have worked around this in our codebase is before mounting checking if there is asyncData property and calling that, getting data and applying that to data of component.

Example code:

import Component from "./_.vue";

if (Component.asyncData) {
    const originalData = Component.data();
    const asyncData = await Component.asyncData({
      $axios,
      route,
      params
      redirect
    });
    Component.data = function() {
      return { ...originalData, ...asyncData };
    };
  }

  const component = shallowMount(Component);

The issue though is if you have something that is expecting the data to fail and use redirect + expecting some of the asyncData to be used inside the lifecycle hook like mount you will have some issues :/

Example excerpt of the JS for our specific scenario:

export default {
  name: "TestComponent",
  data() {
    return {
      productDetails: {},
    };
  },
  mounted() {
    this.track();
  },
  methods: {
    track() {
      this.$gtm.trackEvent({
        event: "pageshow",
        taxonomy: {
          id: this.productDetails.id,
          extra: this.productDetails.extra,
        }
      });
    },
  },
  async asyncData({ $axios, route, params, redirect }) {
    try {
      const result = await $axios.get(`/productDetail`);
      return result;
    } catch {
      redirect('/somewhere-else');
    }
  },
};

Trying to test redirect on error with the above workaround will result in errors along the lines of:

Cannot access id of undefined

As mounted will get triggered as soon as I pass component to mount or shallowMount

@manniL manniL transferred this issue from nuxt/nuxt Sep 28, 2019
@williamweckl
Copy link

@VladDubrovskis you helped me a lot with your code example!!! Thank you!

This should be at the documentation! I have spent a lot of time looking for something like this :(

@ioandev
Copy link

ioandev commented Jun 4, 2020

@debs-obrien
Copy link
Contributor

Thanks for your contributions. We are now closing this repo as docs have now moved to nuxtjs.org using content module. Please continue your contributions on that site especially focusing on the guides folder which is the new docs. Thanks

https://github.com/nuxt/nuxtjs.org/blob/master/README.md

@pi0 pi0 reopened this Aug 4, 2020
@vipulphysiofirst
Copy link

vipulphysiofirst commented Sep 9, 2020

suggest some way to do it now stuck here from 2 days can not able to do a unit test for any Axios request
I am using nuxt + jest for unit testing, when id testing a page it has Axios call in a method like this
IN pay.vue

async pay(){
   try{
     var respone  = this.$axios.get('API_URL_HERE);
     this.fee = response.data;
   } catch(e){
      console.log(e)
   }
 }

and test file pay.spec.js

import { mount } from '@vue/test-utils';
import paynow from '../pages/pay';
import   axios from "axios";
import Vue from 'vue'

jest.mock("axios", () => ({
  get: () => Promise.resolve({ data: [{ val: 1 }] })
}));
 
describe("paynow.vue", () => {
  it("mocking the axios call to get posts should work", async () => {
    var wrapper = mount(paynow);
    wrapper.vm.pay() 
  });
});

But I am getting this error after running it.
TypeError: Cannot read property 'get' of undefined
Axios is injected in the plugin then why it is showing undefined

@Atinux Atinux added the pending label Dec 4, 2020 — with Volta.net
@eduardmavliutov
Copy link

eduardmavliutov commented May 20, 2021

jest.mock("axios", () => ({
get: () => Promise.resolve({ data: [{ val: 1 }] })
}));

@vipulphysiofirst You are not mocking axios right. Better way of doing this is:

describe("paynow.vue", () => {
  it("mocking the axios call to get posts should work", async () => {
    var wrapper = mount(paynow, {
         mocks: {
            $axios: {
                get: () => Promise.resolve({ data: [{ val: 1 }] })
            }
         }
    });
    await wrapper.vm.pay() 
  });
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants