Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn console and debugger in dev #56

Merged
merged 1 commit into from Jul 27, 2019
Merged

feat: warn console and debugger in dev #56

merged 1 commit into from Jul 27, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 27, 2019

Instead of turning off no-console in development and displaying error in production, it would be better to show some warning message for development usage.

Why not turning it off or use error in development:

  • App won't be broken if user adds console.log in dev mode with eslint-loader
  • User can still get warning messages for inappropriate usage instead of a sudden error in ci building or pr checking.

Resolves nuxt/create-nuxt-app#301

@clarkdo clarkdo requested review from aldarund and manniL July 27, 2019 17:22
@manniL manniL merged commit 425a8fa into master Jul 27, 2019
@manniL
Copy link
Member

manniL commented Jul 27, 2019

Makes sense, thank you Clark! ☺️

@manniL manniL deleted the no-console-warn branch July 27, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no console.log warnings anymore
2 participants