.github/workflows/ci.yaml

@@ -15,10 +15,10 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        node: [10, 12]
+        node: [12, 14, 17]
 
     steps:
-      - uses: actions/setup-node@v1
+      - uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
 

.husky/.gitignore

@@ -0,0 +1 @@
+_

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+yarn lint-staged

CHANGELOG.md

@@ -2,6 +2,22 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [3.0.0](https://github.com/nuxt/eslint-plugin-nuxt/compare/v2.0.2...v3.0.0) (2021-10-24)
+
+### [2.0.2](https://github.com/nuxt/eslint-plugin-nuxt/compare/v2.0.0...v2.0.2) (2021-10-24)
+
+
+### Bug Fixes
+
+* disallow `process.browser` in `no-env-in-hooks` ([#127](https://github.com/nuxt/eslint-plugin-nuxt/issues/127)) ([07299c0](https://github.com/nuxt/eslint-plugin-nuxt/commit/07299c0ef16dc8efeef19bb2a29df9381aa99e77))
+
+### [2.0.1](https://github.com/nuxt/eslint-plugin-nuxt/compare/v2.0.0...v2.0.1) (2021-10-24)
+
+
+### Bug Fixes
+
+* disallow `process.browser` in `no-env-in-hooks` ([#127](https://github.com/nuxt/eslint-plugin-nuxt/issues/127)) ([07299c0](https://github.com/nuxt/eslint-plugin-nuxt/commit/07299c0ef16dc8efeef19bb2a29df9381aa99e77))
+
 ## [2.0.0](https://github.com/nuxt/eslint-plugin-nuxt/compare/v1.0.0...v2.0.0) (2020-11-14)
 
 ## [1.0.0](https://github.com/nuxt/eslint-plugin-nuxt/compare/v0.5.2...v1.0.0) (2020-05-12)

docs/rules/no-env-in-hooks.md

@@ -1,12 +1,12 @@
 # nuxt/no-env-in-hooks
 
-> Disallow `process.server` and `process.client` in the following lifecycle hooks: `beforeMount`, `mounted`, `beforeUpdate`, `updated`, `activated`, `deactivated`, `beforeDestroy` and `destroyed`.
+> Disallow `process.server`, `process.client` and `process.browser` in the following lifecycle hooks: `beforeMount`, `mounted`, `beforeUpdate`, `updated`, `activated`, `deactivated`, `beforeDestroy` and `destroyed`.
 
 - :gear: This rule is included in `"plugin:nuxt/base"`.
 
 ## Rule Details
 
-This rule is for preventing using `process.server/process.client` in client only Vue lifecycle hooks since they're only executed in client side.
+This rule is for preventing using `process.server`/`process.client`/`process.browser` in client only Vue lifecycle hooks since they're only executed in client side.
 
 Examples of **incorrect** code for this rule:
 
@@ -22,6 +22,11 @@ export default {
     if (process.client) {
       const foo = 'bar'
     }
+  },
+  beforeDestroy() {
+    if (process.browser) {
+      const foo = 'bar'
+    }
   }
 }
 
@@ -38,6 +43,9 @@ export default {
   },
   beforeMount() {
     const foo = 'bar'
+  },
+  beforeDestroy() {
+    const foo = 'bar'
   }
 }
 

lib/rules/__tests__/no-env-in-hooks.test.js

@@ -1,5 +1,5 @@
 /**
- * @fileoverview disallow `process.server/process.client` in `Vue Lifecycle Hooks`
+ * @fileoverview disallow `process.server`/`process.client`/`process.browser` in `Vue Lifecycle Hooks`
  * @author Xin Du <clark.duxin@gmail.com>
  */
 'use strict'
@@ -34,6 +34,9 @@ ruleTester.run('no-env-in-hooks', rule, {
           },
           beforeMount() {
             const foo = 'bar'
+          },
+          beforeDestroy() {
+            const foo = 'bar'
           }
         }
       `,
@@ -55,6 +58,11 @@ ruleTester.run('no-env-in-hooks', rule, {
             if(process.client) {
               const foo = 'bar'
             }
+          },
+          beforeDestroy() {
+            if(process.browser) {
+              const foo = 'bar'
+            }
           }
         }
       `,
@@ -64,6 +72,9 @@ ruleTester.run('no-env-in-hooks', rule, {
       }, {
         message: 'Unexpected process.client in beforeMount.',
         type: 'MemberExpression'
+      }, {
+        message: 'Unexpected process.browser in beforeDestroy.',
+        type: 'MemberExpression'
       }],
       parserOptions
     },
@@ -80,6 +91,11 @@ ruleTester.run('no-env-in-hooks', rule, {
             if(process['server']) {
               const foo = 'bar'
             }
+          },
+          beforeDestroy() {
+            if(process['browser']) {
+              const foo = 'bar'
+            }
           }
         }
       `,
@@ -89,6 +105,9 @@ ruleTester.run('no-env-in-hooks', rule, {
       }, {
         message: 'Unexpected process.server in beforeMount.',
         type: 'MemberExpression'
+      }, {
+        message: 'Unexpected process.browser in beforeDestroy.',
+        type: 'MemberExpression'
       }],
       parserOptions
     }

lib/rules/no-env-in-hooks.js

@@ -1,5 +1,5 @@
 /**
- * @fileoverview disallow process.server and process.client in the following lifecycle hooks: beforeMount, mounted, beforeUpdate, updated, activated, deactivated, beforeDestroy and destroyed
+ * @fileoverview disallow process.server, process.client and process.browser in the following lifecycle hooks: beforeMount, mounted, beforeUpdate, updated, activated, deactivated, beforeDestroy and destroyed
  * @author Xin Du <clark.duxin@gmail.com>
  */
 'use strict'
@@ -27,7 +27,7 @@ module.exports = {
     const forbiddenNodes = []
     const options = context.options[0] || {}
 
-    const ENV = ['server', 'client']
+    const ENV = ['server', 'client', 'browser']
     const HOOKS = new Set(['beforeMount', 'mounted', 'beforeUpdate', 'updated', 'activated', 'deactivated', 'beforeDestroy', 'destroyed'].concat(options.methods || []))
 
     // ----------------------------------------------------------------------

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-nuxt",
-  "version": "2.0.0",
+  "version": "3.0.0",
   "description": "ESLint plugin for Nuxt.js",
   "author": "Clark Du <clarkdo@gmail.com>",
   "license": "MIT",
@@ -25,33 +25,33 @@
   "scripts": {
     "test": "jest --silent",
     "lint": "eslint ./",
-    "release": "standard-version"
-  },
-  "husky": {
-    "hooks": {
-      "pre-commit": "lint-staged"
-    }
+    "release": "standard-version",
+    "postinstall": "husky install",
+    "prepublishOnly": "pinst --disable",
+    "postpublish": "pinst --enable",
+    "prepare": "husky install"
   },
   "lint-staged": {
     "*.js": [
       "eslint"
     ]
   },
   "devDependencies": {
-    "eslint": "^7.13.0",
-    "eslint-config-standard": "^16.0.1",
-    "eslint-plugin-import": "^2.22.1",
+    "eslint": "^8.1.0",
+    "eslint-config-standard": "^16.0.3",
+    "eslint-plugin-import": "^2.25.2",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-standard": "^4.1.0",
-    "husky": "^4.3.0",
-    "jest": "^26.6.3",
-    "lint-staged": "^10.5.1",
-    "standard-version": "^9.0.0"
+    "eslint-plugin-promise": "^5.1.1",
+    "eslint-plugin-standard": "^5.0.0",
+    "husky": "^7.0.4",
+    "jest": "^27.3.1",
+    "lint-staged": "^11.2.4",
+    "pinst": "^2.1.6",
+    "standard-version": "^9.3.2"
   },
   "dependencies": {
-    "eslint-plugin-vue": "^7.1.0",
-    "semver": "^7.3.2",
-    "vue-eslint-parser": "^7.1.1"
+    "eslint-plugin-vue": "^7.20.0",
+    "semver": "^7.3.5",
+    "vue-eslint-parser": "^8.0.0"
   }
 }