feat: turn on consistent-type-imports

nuxt · Mar 27, 2024 · 6a61b37 · 6a61b37
1 parent 6bbc357
commit 6a61b37
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 15 deletions.
diff --git a/packages/eslint-config/src/flat/configs/disables.ts b/packages/eslint-config/src/flat/configs/disables.ts
@@ -1,7 +1,7 @@
 import { join } from 'pathe'
 import { GLOB_EXTS } from '../constants'
 import type { NuxtESLintConfigOptions } from '../types'
-import { FlatConfigItem } from 'eslint-flat-config-utils'
+import type { FlatConfigItem } from 'eslint-flat-config-utils'
 
 export default function disables(options: NuxtESLintConfigOptions): FlatConfigItem[] {
   const dirs = options.dirs ?? {}

diff --git a/packages/eslint-config/src/flat/configs/javascript.ts b/packages/eslint-config/src/flat/configs/javascript.ts
@@ -1,6 +1,6 @@
 // @ts-expect-error missing types
 import pluginESLint from '@eslint/js'
-import { FlatConfigItem } from 'eslint-flat-config-utils'
+import type { FlatConfigItem } from 'eslint-flat-config-utils'
 import globals from 'globals'
 
 export default function javascript(): FlatConfigItem[] {

diff --git a/packages/eslint-config/src/flat/configs/nuxt.ts b/packages/eslint-config/src/flat/configs/nuxt.ts
@@ -2,7 +2,7 @@ import { join } from 'pathe'
 import type { NuxtESLintConfigOptions } from '../types'
 import nuxtPlugin from '@nuxt/eslint-plugin'
 import { GLOB_EXTS } from '../constants'
-import { FlatConfigItem } from 'eslint-flat-config-utils'
+import type { FlatConfigItem } from 'eslint-flat-config-utils'
 
 export default function nuxt(options: NuxtESLintConfigOptions): FlatConfigItem[] {
   const dirs = options.dirs ?? {}

diff --git a/packages/eslint-config/src/flat/configs/typescript.ts b/packages/eslint-config/src/flat/configs/typescript.ts
@@ -1,6 +1,6 @@
 import * as parserTs from '@typescript-eslint/parser'
 import pluginTs from '@typescript-eslint/eslint-plugin'
-import { FlatConfigItem } from 'eslint-flat-config-utils'
+import type { FlatConfigItem } from 'eslint-flat-config-utils'
 
 export default function typescript(): FlatConfigItem[] {
   return [
@@ -13,14 +13,16 @@ export default function typescript(): FlatConfigItem[] {
     },
     {
       name: 'nuxt:typescript',
-      files: ['**/*.ts', '**/*.tsx', '**/*.mts', '**/*.cts'],
+      files: ['**/*.ts', '**/*.tsx', '**/*.mts', '**/*.cts', '**/*.vue'],
       languageOptions: {
         parser: parserTs,
       },
       rules: {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         ...pluginTs.configs['eslint-recommended'].overrides![0].rules as any,
         ...pluginTs.configs.recommended.rules,
+
+        '@typescript-eslint/consistent-type-imports': ['error', { disallowTypeAnnotations: false, prefer: 'type-imports' }],
       },
     },
     {

diff --git a/packages/eslint-config/src/flat/configs/vue.ts b/packages/eslint-config/src/flat/configs/vue.ts
@@ -3,9 +3,9 @@ import * as parserTs from '@typescript-eslint/parser'
 
 // @ts-expect-error missing types
 import pluginVue from 'eslint-plugin-vue'
-import { NuxtESLintConfigOptions } from '../types'
+import type { NuxtESLintConfigOptions } from '../types'
 import { removeUndefined } from '../utils'
-import { FlatConfigItem } from 'eslint-flat-config-utils'
+import type { FlatConfigItem } from 'eslint-flat-config-utils'
 
 export default function vue(options: NuxtESLintConfigOptions): FlatConfigItem[] {
   return [

diff --git a/packages/eslint-config/src/flat/index.ts b/packages/eslint-config/src/flat/index.ts
@@ -6,7 +6,8 @@ import javascript from './configs/javascript'
 import typescript from './configs/typescript'
 import vue from './configs/vue'
 import stylistic from './configs/stylistic'
-import { pipe, FlatConfigPipeline, FlatConfigItem } from 'eslint-flat-config-utils'
+import type { FlatConfigPipeline, FlatConfigItem } from 'eslint-flat-config-utils'
+import { pipe } from 'eslint-flat-config-utils'
 
 export * from './types'
 

diff --git a/packages/eslint-config/src/flat/types.ts b/packages/eslint-config/src/flat/types.ts
@@ -1,4 +1,4 @@
-import { StylisticCustomizeOptions } from '@stylistic/eslint-plugin'
+import type { StylisticCustomizeOptions } from '@stylistic/eslint-plugin'
 
 export interface NuxtESLintFeaturesOptions {
   /**

diff --git a/packages/eslint-config/src/legacy.ts b/packages/eslint-config/src/legacy.ts
@@ -1,5 +1,5 @@
 import '@rushstack/eslint-patch/modern-module-resolution'
-import { ESLint } from 'eslint'
+import type { ESLint } from 'eslint'
 
 const config: ESLint.ConfigData = {
   parserOptions: {

diff --git a/packages/module/src/module.ts b/packages/module/src/module.ts
@@ -1,6 +1,6 @@
 import { defineNuxtModule } from '@nuxt/kit'
 import { setupConfigGen } from './modules/config'
-import { ModuleOptions } from './types'
+import type { ModuleOptions } from './types'
 
 export * from './types'
 

diff --git a/packages/module/src/modules/checker.ts b/packages/module/src/modules/checker.ts
@@ -1,5 +1,5 @@
-import { Nuxt } from '@nuxt/schema'
-import { CheckerOptions, ModuleOptions } from '../module'
+import type { Nuxt } from '@nuxt/schema'
+import type { CheckerOptions, ModuleOptions } from '../module'
 import { addVitePlugin, addWebpackPlugin, useLogger } from '@nuxt/kit'
 import { relative, resolve } from 'pathe'
 import { watch } from 'chokidar'

diff --git a/packages/module/src/modules/config.ts b/packages/module/src/modules/config.ts
@@ -6,7 +6,7 @@ import { relative, resolve } from 'pathe'
 import { getPort } from 'get-port-please'
 import type { ESLintConfigGenAddon } from '../types'
 import type { NuxtESLintConfigOptions } from '@nuxt/eslint-config/flat'
-import { ConfigGenOptions, ModuleOptions } from '../module'
+import type { ConfigGenOptions, ModuleOptions } from '../module'
 import { createAddonGlobals } from '../config-addons/globals'
 
 export async function setupConfigGen(options: ModuleOptions, nuxt: Nuxt) {

diff --git a/packages/module/src/types.ts b/packages/module/src/types.ts
@@ -1,7 +1,7 @@
 import type { Import } from 'unimport'
 import type { ESLintPluginOptions as ViteCheckerOptions } from 'vite-plugin-eslint2'
 import type { Options as WebpackCheckerOptions } from 'eslint-webpack-plugin'
-import { NuxtESLintFeaturesOptions } from '@nuxt/eslint-config/flat'
+import type { NuxtESLintFeaturesOptions } from '@nuxt/eslint-config/flat'
 
 declare module '@nuxt/schema' {
   interface NuxtHooks {