feat(eslint-config): typescript strict by default, make config names …

…more consistent
nuxt · Mar 29, 2024 · d77ebe7 · d77ebe7
1 parent 2efd732
commit d77ebe7
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/packages/eslint-config/src/flat/configs/disables.ts b/packages/eslint-config/src/flat/configs/disables.ts
@@ -28,7 +28,7 @@ export default function disables(options: NuxtESLintConfigOptions): FlatConfigIt
 
   if (fileRoutes.length) {
     configs.push({
-      name: 'nuxt:vue-routes-disables',
+      name: 'nuxt:vue:routes:disables',
       files: fileRoutes,
       rules: {
         'vue/multi-word-component-names': 'off',

diff --git a/packages/eslint-config/src/flat/configs/nuxt.ts b/packages/eslint-config/src/flat/configs/nuxt.ts
@@ -28,7 +28,7 @@ export default function nuxt(options: NuxtESLintConfigOptions): FlatConfigItem[]
 
   if (fileSingleRoot.length)
     configs.push({
-      name: 'nuxt:vue-single-root',
+      name: 'nuxt:vue:single-root',
       files: fileSingleRoot,
       rules: {
         'vue/no-multiple-template-root': 'error',

diff --git a/packages/eslint-config/src/flat/configs/typescript.ts b/packages/eslint-config/src/flat/configs/typescript.ts
@@ -5,7 +5,7 @@ import type { FlatConfigItem } from 'eslint-flat-config-utils'
 export default function typescript(): FlatConfigItem[] {
   return [
     {
-      name: 'nuxt:setup:typescript',
+      name: 'nuxt:typescript:setup',
       plugins: {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         '@typescript-eslint': pluginTs as any,
@@ -21,12 +21,14 @@ export default function typescript(): FlatConfigItem[] {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         ...pluginTs.configs['eslint-recommended'].overrides![0].rules as any,
         ...pluginTs.configs.recommended.rules,
+        ...pluginTs.configs.strict.rules,
 
+        '@typescript-eslint/no-non-null-assertion': 'off',
         '@typescript-eslint/consistent-type-imports': ['error', { disallowTypeAnnotations: false, prefer: 'type-imports' }],
       },
     },
     {
-      name: 'nuxt:typescript-disables',
+      name: 'nuxt:typescript:disables',
       files: ['**/*.ts', '**/*.tsx', '**/*.mts', '**/*.cts', '**/*.vue'],
       rules: {
         // The core 'no-unused-vars' rules (in the eslint:recommended ruleset)

diff --git a/packages/eslint-config/src/flat/configs/vue.ts b/packages/eslint-config/src/flat/configs/vue.ts
@@ -12,14 +12,11 @@ export default function vue(options: NuxtESLintConfigOptions): FlatConfigItem[]
 
   return [
     {
-      name: 'nuxt:setup-vue',
+      name: 'nuxt:vue:setup',
       plugins: {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         vue: pluginVue as any,
       },
-    },
-    {
-      name: 'nuxt:vue-language-options',
       languageOptions: {
         parserOptions: {
           ecmaVersion: 'latest',

diff --git a/packages/module/src/types.ts b/packages/module/src/types.ts
@@ -115,5 +115,5 @@ export type Awaitable<T> = T | Promise<T>
 
 export type ESLintConfigGenAddon = {
   name: string
-  getConfigs: () => Awaitable<ESLintConfigGenAddonResult | void>
+  getConfigs: () => Awaitable<ESLintConfigGenAddonResult | undefined>
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -21,7 +21,9 @@
     }
   },
   "exclude": [
+    "**/dist/**",
+    "**/node_modules/**",
     "playground",
-    "docs"
+    "docs",
   ]
 }