Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running eslint with version 12.0.0 of @nuxtjs/eslint-config turns on the --report-unused-disable-directive flag #243

Open
ericpromislow opened this issue Dec 2, 2022 · 0 comments
Labels
nuxt2-legacy Issues related to the legacy Nuxt 2 eslint config

Comments

@ericpromislow
Copy link

ericpromislow commented Dec 2, 2022

Easiiest way to repro this is to pull down

https://github.com/rancher-sandbox/rancher-desktop

You need to first run npm i (goes much faster if you change the "postinstall" line in package.json around line 41 to echo skipping node...).

Then run a command like:

node node_modules/eslint/bin/eslint.js --ignore-path=.gitignore --ext mjs,js,ts,tsx,vue  pkg/rancher-desktop/backend/k3sHelper.ts

For this file, I get this output:

/Users/ericp/workspace/rancher/desktop/pkg/rancher-desktop/backend/k3sHelper.ts
  47:3  warning  Unused eslint-disable directive (no problems were reported from 'camelcase')
  50:5  warning  Unused eslint-disable directive (no problems were reported from 'camelcase')

✖ 2 problems (0 errors, 2 warnings)
  0 errors and 2 warnings potentially fixable with the `--fix` option.

Now if the version field in package.json is "^12.0.0" (shouldn't be much higher if this is still open), change it to "11.0.0", rerun npm i and the above node ... eslint.js , and you should get no output.

I looked at the diffs for tags v11.0.0 and v12.0.0 and didn't see any code that looks like it's causing a problem, but I didn't trace into differences in the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nuxt2-legacy Issues related to the legacy Nuxt 2 eslint config
Projects
None yet
Development

No branches or pull requests

2 participants