Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-config-legacy): also check for nuxt-edge #264

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix(eslint-config-legacy): also check for nuxt-edge #264

merged 1 commit into from
Jan 16, 2023

Conversation

mercs600
Copy link
Contributor

fixes #263

@Atinux Atinux requested a review from danielroe January 16, 2023 10:29
danielroe
danielroe approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you!

@pi0
Copy link
Member

pi0 commented Jan 16, 2023

For reference, nuxt/kit also checks for nuxt3 (https://github.com/nuxt/framework/blob/main/packages/kit/src/loader/nuxt.ts#L31). However, should be fine since the majority of users should use npm:nuxt3 alias should be good 👍🏼

@danielroe danielroe changed the title fix: apply legacy config for nuxt-edge fix(eslint-config-legacy): also check for nuxt-edge Jan 16, 2023
@danielroe danielroe merged commit 30cfb4e into nuxt:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration for vue2 doesn't work when nuxt-edge used
3 participants
@mercs600 @pi0 @danielroe