From e76ebdddd05f7df54c8d6ccf3340ecc6ca9abfac Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Wed, 9 Nov 2022 09:59:23 +0100 Subject: [PATCH] fix(nuxt): allow cookies to be set to `null` to unset them (#8769) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Magyar Balázs --- packages/nuxt/src/app/composables/cookie.ts | 2 +- test/fixtures/basic/types.ts | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/nuxt/src/app/composables/cookie.ts b/packages/nuxt/src/app/composables/cookie.ts index 9df2d82852e..7a7d6eb9374 100644 --- a/packages/nuxt/src/app/composables/cookie.ts +++ b/packages/nuxt/src/app/composables/cookie.ts @@ -15,7 +15,7 @@ export interface CookieOptions extends _CookieOptions { default?: () => T | Ref } -export interface CookieRef extends Ref {} +export interface CookieRef extends Ref {} const CookieDefaults: CookieOptions = { path: '/', diff --git a/test/fixtures/basic/types.ts b/test/fixtures/basic/types.ts index 69899120afc..c5cb34002b3 100644 --- a/test/fixtures/basic/types.ts +++ b/test/fixtures/basic/types.ts @@ -154,8 +154,9 @@ describe('composables', () => { expectTypeOf(useState('test', () => ref('hello'))).toEqualTypeOf>() expectTypeOf(useState('test', () => 'hello')).toEqualTypeOf>() - expectTypeOf(useCookie('test', { default: () => ref(500) })).toEqualTypeOf>() - expectTypeOf(useCookie('test', { default: () => 500 })).toEqualTypeOf>() + expectTypeOf(useCookie('test', { default: () => ref(500) })).toEqualTypeOf>() + expectTypeOf(useCookie('test', { default: () => 500 })).toEqualTypeOf>() + useCookie('test').value = null expectTypeOf(useAsyncData('test', () => Promise.resolve(500), { default: () => ref(500) }).data).toEqualTypeOf>() expectTypeOf(useAsyncData('test', () => Promise.resolve(500), { default: () => 500 }).data).toEqualTypeOf>()