From 72a14eaaef1224f4e94ca4904e3ce3977e1cd4ce Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Thu, 15 Sep 2022 23:06:31 +0100 Subject: [PATCH 1/5] fix(vite): provide fallback stack + reason --- packages/vite/src/runtime/vite-node.mjs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/vite/src/runtime/vite-node.mjs b/packages/vite/src/runtime/vite-node.mjs index 0784d29d8a3..aeb20cb74db 100644 --- a/packages/vite/src/runtime/vite-node.mjs +++ b/packages/vite/src/runtime/vite-node.mjs @@ -40,6 +40,8 @@ function createRunner () { if (!errorData) { throw err } + errorData.stack = errorData.stack || err.stack + errorData.reason = errorData.reason || err.message let _err try { const { message, stack } = formatViteError(errorData) From fd0f5af545af1baff952fdc4348bd717e49d93c0 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Fri, 16 Sep 2022 11:06:41 +0100 Subject: [PATCH 2/5] fix: remove stack --- packages/vite/src/runtime/vite-node.mjs | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/vite/src/runtime/vite-node.mjs b/packages/vite/src/runtime/vite-node.mjs index aeb20cb74db..c8042ef47b5 100644 --- a/packages/vite/src/runtime/vite-node.mjs +++ b/packages/vite/src/runtime/vite-node.mjs @@ -40,7 +40,6 @@ function createRunner () { if (!errorData) { throw err } - errorData.stack = errorData.stack || err.stack errorData.reason = errorData.reason || err.message let _err try { From 0901b8a21f740fe253ec3e1551abfa7057622f36 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Date: Fri, 16 Sep 2022 19:54:26 +0200 Subject: [PATCH 3/5] improve fallback --- packages/vite/src/runtime/vite-node.mjs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/vite/src/runtime/vite-node.mjs b/packages/vite/src/runtime/vite-node.mjs index c8042ef47b5..51cbd9cd030 100644 --- a/packages/vite/src/runtime/vite-node.mjs +++ b/packages/vite/src/runtime/vite-node.mjs @@ -40,7 +40,6 @@ function createRunner () { if (!errorData) { throw err } - errorData.reason = errorData.reason || err.message let _err try { const { message, stack } = formatViteError(errorData) @@ -51,11 +50,11 @@ function createRunner () { }) } catch (err) { // This should not happen unless there is an internal error with formatViteError! - consola.error('Error while formatting vite error:', errorData) + consola.error('Internal error while formatting error for transformating', id, errorData) throw createError({ statusMessage: 'Vite Error', message: errorData.message || 'Vite Error', - stack: 'Vite Error\nat [check console]' + stack: `Internal error while formatting error\nat ${id}` }) } throw _err From 2279bc3a1bc97847ada33e992a543f4c8f383580 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Date: Fri, 16 Sep 2022 19:58:01 +0200 Subject: [PATCH 4/5] keep check console tag --- packages/vite/src/runtime/vite-node.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/runtime/vite-node.mjs b/packages/vite/src/runtime/vite-node.mjs index 51cbd9cd030..aed08cd324c 100644 --- a/packages/vite/src/runtime/vite-node.mjs +++ b/packages/vite/src/runtime/vite-node.mjs @@ -54,7 +54,7 @@ function createRunner () { throw createError({ statusMessage: 'Vite Error', message: errorData.message || 'Vite Error', - stack: `Internal error while formatting error\nat ${id}` + stack: `Internal error while formatting error\nat ${id} [check console]` }) } throw _err @@ -64,7 +64,7 @@ function createRunner () { } function formatViteError (errorData) { - const errorCode = errorData.name || errorData.reasonCode || errorData.code + const errorCode = errorData.foo.name || errorData.reasonCode || errorData.code const frame = errorData.frame || errorData.source || errorData.pluginCode const getLocId = (locObj = {}) => locObj.file || locObj.id || locObj.url || '' From c8bf7130a4460135f2871bf3f3fd7c310e43f726 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Date: Fri, 16 Sep 2022 20:10:39 +0200 Subject: [PATCH 5/5] improve --- packages/vite/src/runtime/vite-node.mjs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/runtime/vite-node.mjs b/packages/vite/src/runtime/vite-node.mjs index aed08cd324c..aceffde41dd 100644 --- a/packages/vite/src/runtime/vite-node.mjs +++ b/packages/vite/src/runtime/vite-node.mjs @@ -48,13 +48,14 @@ function createRunner () { message, stack }) - } catch (err) { - // This should not happen unless there is an internal error with formatViteError! - consola.error('Internal error while formatting error for transformating', id, errorData) + } catch (formatError) { + consola.warn('Internal nuxt error while formatting vite-node error. Please report this!', formatError) + const message = `[vite-node] [TransformError] ${errorData?.message || '-'}` + consola.error(message, errorData) throw createError({ statusMessage: 'Vite Error', - message: errorData.message || 'Vite Error', - stack: `Internal error while formatting error\nat ${id} [check console]` + message, + stack: `${message}\nat ${id}\n` + (errorData?.stack || '') }) } throw _err @@ -64,7 +65,7 @@ function createRunner () { } function formatViteError (errorData) { - const errorCode = errorData.foo.name || errorData.reasonCode || errorData.code + const errorCode = errorData.name || errorData.reasonCode || errorData.code const frame = errorData.frame || errorData.source || errorData.pluginCode const getLocId = (locObj = {}) => locObj.file || locObj.id || locObj.url || ''