From ad49b34b8682abcbccc5394293ef47e9a36cb2ae Mon Sep 17 00:00:00 2001 From: Alex C Date: Tue, 11 Oct 2022 10:48:45 +0200 Subject: [PATCH 1/3] fix(nuxt): no inline styles for client side rendering --- packages/nuxt/src/core/runtime/nitro/renderer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nuxt/src/core/runtime/nitro/renderer.ts b/packages/nuxt/src/core/runtime/nitro/renderer.ts index 828aec1a84f..14d06112058 100644 --- a/packages/nuxt/src/core/runtime/nitro/renderer.ts +++ b/packages/nuxt/src/core/runtime/nitro/renderer.ts @@ -197,7 +197,7 @@ export default defineRenderHandler(async (event) => { const renderedMeta = await ssrContext.renderMeta?.() ?? {} // Render inline styles - const inlinedStyles = process.env.NUXT_INLINE_STYLES + const inlinedStyles = process.env.NUXT_INLINE_STYLES && !(process.env.NUXT_NO_SSR || ssrContext.noSSR) ? await renderInlineStyles(ssrContext.modules ?? ssrContext._registeredComponents ?? []) : '' From f95ee43cd55a1e6995ef054d2798886c4e25850c Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Tue, 11 Oct 2022 23:13:55 +0100 Subject: [PATCH 2/3] test: add failing test --- test/fixtures/basic/assets/global.css | 1 + 1 file changed, 1 insertion(+) diff --git a/test/fixtures/basic/assets/global.css b/test/fixtures/basic/assets/global.css index 382b2400485..b4b49a96375 100644 --- a/test/fixtures/basic/assets/global.css +++ b/test/fixtures/basic/assets/global.css @@ -1,3 +1,4 @@ :root { --global: 'global'; + --asset: url('~/assets/logo.svg'); } From d63bbdc3008c88be2c24c1c6cc4d8ef3f4639044 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Wed, 12 Oct 2022 00:10:12 +0100 Subject: [PATCH 3/3] test: update snapshot --- test/basic.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/basic.test.ts b/test/basic.test.ts index 65acabfea15..d95d46ff83e 100644 --- a/test/basic.test.ts +++ b/test/basic.test.ts @@ -598,7 +598,7 @@ describe.skipIf(process.env.NUXT_TEST_DEV || process.env.TEST_WITH_WEBPACK)('inl '{--assets:"assets"}', //