Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glide provider and external domain #748

Closed
jeanmatthieud opened this issue Feb 16, 2023 · 2 comments
Closed

Glide provider and external domain #748

jeanmatthieud opened this issue Feb 16, 2023 · 2 comments

Comments

@jeanmatthieud
Copy link
Contributor

Expected output : https://domain.com/glide/https://domain.com/image.jpg?params
Current output : https://domain.com/image.jpg?params
Note: I cannot remove the domain part of the image URL, as it is required by the Glide implementation that I cannot change myself

Since UFO 0.8.6, 'withBase' does not prefix URLs with protocol (unjs/ufo#68), which breaks the 'getImage' implementation of the Glide provider.

From glide.js / latest release:

export const getImage = (src, { modifiers = {}, baseURL = "/" } = {}) => {
  const params = operationsGenerator(modifiers);
  return {
    url: withBase(joinURL(encodePath(src) + (params ? "?" + params : "")), baseURL)
  };
};
Copy link
Contributor

Would you be able to provide a reproduction? 🙏

More info

Why do I need to provide a reproduction?

Reproductions make it possible for us to triage and fix issues quickly with a relatively small team. It helps us discover the source of the problem, and also can reveal assumptions you or we might be making.

What will happen?

If you've provided a reproduction, we'll remove the label and try to reproduce the issue. If we can, we'll mark it as a bug and prioritise it based on its severity and how many people we think it might affect.

If needs reproduction labeled issues don't receive any substantial activity (e.g., new comments featuring a reproduction link), we'll close them. That's not because we don't care! At any point, feel free to comment with a reproduction and we'll reopen it.

How can I create a reproduction?

We have a template for starting with a minimal reproduction:

👉 https://stackblitz.com/github/nuxt/image/tree/main/example

A public GitHub repository is also perfect. 👌

Please ensure that the reproduction is as minimal as possible. See more details in our guide.

You might also find these other articles interesting and/or helpful:

Copy link
Contributor

This issue was closed because it was open for 7 days without a reproduction.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants