Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): clear hide timeout when calling clear() #10086

Merged
merged 4 commits into from Jan 19, 2023

Conversation

arikw
Copy link

@arikw arikw commented Nov 26, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #10085

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 changed the title fix(vue-app): show loading indication even if finished shortly beforehand fix(vue-app): loading indication isn't started if it was stopped less than 500ms beforehand Jun 23, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #10086 (c7d165c) into dev (123206c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10086   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files          94       94           
  Lines        4155     4155           
  Branches     1172     1172           
=======================================
  Hits         2709     2709           
  Misses       1167     1167           
  Partials      279      279           
Flag Coverage Δ
unittests 65.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123206c...c7d165c. Read the comment docs.

@arikw
Copy link
Author

arikw commented Jun 24, 2022

@pi0 thanks. Is there anything else I'm required to do to get this PR merged?

@danielroe danielroe added the 2.x label Jan 18, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@danielroe danielroe changed the title fix(vue-app): loading indication isn't started if it was stopped less than 500ms beforehand fix(vue-app): clear hide timeout when calling clear() Jan 19, 2023
@danielroe danielroe merged commit 0088d13 into nuxt:2.x-dev Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading indication isn't started if it was stopped less than 500ms beforehand
4 participants