fix(vue-app): call ssrContext.unsetMutationObserver only if it exists #10132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Resolves: #10131
ssrContext.unsetMutationObserver
is set after router middleware are evaluated. This causes a problem because if a middleware callserror
, then the app callsrenderErrorPage
which in turns callsssrContext.unsetMutationObserver()
in thebeforeRender
function, causing an error.https://github.com/nuxt/nuxt.js/blob/dev/packages/vue-app/template/server.js#L137
https://github.com/nuxt/nuxt.js/blob/dev/packages/vue-app/template/server.js#L209
https://github.com/nuxt/nuxt.js/blob/dev/packages/vue-app/template/server.js#L216
Checklist: