Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): allow files with .cjs extension to be transpiled #10340

Merged
merged 3 commits into from Jun 23, 2022
Merged

fix(webpack): allow files with .cjs extension to be transpiled #10340

merged 3 commits into from Jun 23, 2022

Conversation

rchl
Copy link

@rchl rchl commented Mar 19, 2022

Fixes #10339

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Not sure if you consider it a bug fix or a feature but it seems like a bug to me.

Resolves #10339

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #10340 (dfe9a74) into dev (e5efc25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10340   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files          94       94           
  Lines        4155     4155           
  Branches     1172     1172           
=======================================
  Hits         2709     2709           
  Misses       1167     1167           
  Partials      279      279           
Flag Coverage Δ
unittests 65.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/webpack/src/config/base.js 65.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5efc25...dfe9a74. Read the comment docs.

@rchl
Copy link
Author

rchl commented Mar 21, 2022

@danielroe
Copy link
Member

@rchl Agreed. Would you update that one as well?

@rchl
Copy link
Author

rchl commented Mar 21, 2022

I will but note that the fix works without this change so I'm not sure what's the exact purpose of this.

@rchl
Copy link
Author

rchl commented May 18, 2022

Any plans to merge and release a new Nuxt 2 version?

@danielroe danielroe requested a review from pi0 May 18, 2022 21:45
@pi0 pi0 changed the title fix: allow files with .cjs extension to be transpiled fix: allow files with .cjs extension to be transpiled Jun 23, 2022
@pi0
Copy link
Member

pi0 commented Jun 23, 2022

Thanks for working on this pull request @rchl and sorry it took long to merge. CI was failing because of dependencies. And indeed we plan to make at least two minor versions for Nuxt 2 and including this fix as well.

@pi0 pi0 changed the title fix: allow files with .cjs extension to be transpiled fix(webpack): allow files with .cjs extension to be transpiled Jun 23, 2022
@pi0 pi0 merged commit 7a25294 into nuxt:dev Jun 23, 2022
@pi0 pi0 mentioned this pull request Jun 23, 2022
@rchl rchl deleted the fix/transpile-cjs branch June 24, 2022 07:22
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript files with .cjs extension can not be transpiled
5 participants