Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): resolve .wasm extension with lower priority #10676

Merged
merged 1 commit into from Sep 3, 2022
Merged

fix(webpack): resolve .wasm extension with lower priority #10676

merged 1 commit into from Sep 3, 2022

Conversation

nieyuyao
Copy link

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adjust the priority of the .wasm extension to the lowest, this will fix #10665 .

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #10676 (3ba834b) into dev (86570cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10676   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files          94       94           
  Lines        4155     4155           
  Branches     1172     1172           
=======================================
  Hits         2709     2709           
  Misses       1167     1167           
  Partials      279      279           
Flag Coverage Δ
unittests 65.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/webpack/src/config/base.js 65.89% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

There doesn't seem to be a reason .wasm was first other than that it was the default in webpack: see #3261 - and it no longer is.

@danielroe danielroe requested a review from clarkdo August 31, 2022 13:33
@pi0 pi0 changed the title fix: .wasm extension adjusted to low priority fix(webpack): resolve .wasm extension with lower priority Sep 3, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit dd3ed75 into nuxt:dev Sep 3, 2022
@nieyuyao nieyuyao deleted the fix/wasm-resolve branch September 4, 2022 02:29
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*env in ./node_modules/xxx error
4 participants