Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): downgrade @types packages depending on webpack 5 #18827

Merged
merged 1 commit into from Feb 6, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #18817

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This reverts two type dependency upgrades that pull in webpack@5, including one in a patch. πŸ’€

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Feb 6, 2023
@codesandbox
Copy link

codesandbox bot commented Feb 6, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codecov-commenter
Copy link

Codecov Report

Base: 66.40% // Head: 66.40% // No change to project coverage πŸ‘

Coverage data is based on head (cc4362e) compared to base (65e87b2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x   #18827   +/-   ##
=======================================
  Coverage   66.40%   66.40%           
=======================================
  Files          93       93           
  Lines        4081     4081           
  Branches     1151     1151           
=======================================
  Hits         2710     2710           
  Misses       1111     1111           
  Partials      260      260           
Flag Coverage Ξ”
unittests 66.40% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@danielroe danielroe merged commit 2443205 into 2.x Feb 6, 2023
@danielroe danielroe deleted the fix/webpack-5 branch February 6, 2023 17:29
This was referenced Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants