New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): import Location
from vue-router
#18908
Conversation
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportBase: 66.42% // Head: 66.42% // No change to project coverage π
Additional details and impacted files@@ Coverage Diff @@
## 2.x #18908 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 93 93
Lines 4080 4080
Branches 1154 1154
=======================================
Hits 2710 2710
Misses 1107 1107
Partials 263 263
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Location
from vue-router
Could you publish the nuxt type pkg? Hitting this issue now |
It should already be published. |
My bad. For whatever reason it didn't show up when I ran |
I was also confused about the type packages not being published - it looks like they're not being marked as Since v3 doesn't require the types package, could we keep publishing types for 2.x as |
Indeed. That's already been fixed in the release script and the next version will be tagged as latest. |
π Linked issue
β Type of change
π Description
Fixed
vue-router
'sLocation
type was not imported and globalLocation
type was used forredirect
argument type.https://github.com/nuxt/nuxt/blob/2.x/packages/types/app/index.d.ts#L60-L61
π Checklist