Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): import Location from vue-router #18908

Merged
merged 1 commit into from Feb 9, 2023

Conversation

h-kishi
Copy link

@h-kishi h-kishi commented Feb 9, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixed vue-router's Location type was not imported and global Location type was used for redirect argument type.

https://github.com/nuxt/nuxt/blob/2.x/packages/types/app/index.d.ts#L60-L61

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 9, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Base: 66.42% // Head: 66.42% // No change to project coverage πŸ‘

Coverage data is based on head (c26be57) compared to base (daed62a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x   #18908   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files          93       93           
  Lines        4080     4080           
  Branches     1154     1154           
=======================================
  Hits         2710     2710           
  Misses       1107     1107           
  Partials      263      263           
Flag Coverage Ξ”
unittests 66.42% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@danielroe danielroe changed the title fix(types): Location not imported fix(types): import Location from vue-router Feb 9, 2023
@danielroe danielroe merged commit 75cbb47 into nuxt:2.x Feb 9, 2023
@h-kishi h-kishi deleted the h-kishi/fix-no-location branch February 9, 2023 06:45
@danielroe danielroe mentioned this pull request Feb 13, 2023
@tjhiggins
Copy link

tjhiggins commented Feb 13, 2023

Could you publish the nuxt type pkg? Hitting this issue now

Copy link
Member

It should already be published.

@tjhiggins
Copy link

It should already be published.

My bad. For whatever reason it didn't show up when I ran npm outdated, but I see on npm page. Thanks.

@blimmer
Copy link

blimmer commented Mar 14, 2023

I was also confused about the type packages not being published - it looks like they're not being marked as latest anymore, so tools like npm outdated, npm-check-updates, yarn upgrade-interactive, etc. don't show an upgrade past 2.16.0 as available.

Screenshot 2023-03-13 at 18 09 12

Since v3 doesn't require the types package, could we keep publishing types for 2.x as latest?

@danielroe
Copy link
Member

Indeed. That's already been fixed in the release script and the next version will be tagged as latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants