Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): upgrade md4 -> md5 on node > 16 #19108

Merged
merged 2 commits into from Feb 20, 2023
Merged

fix(config): upgrade md4 -> md5 on node > 16 #19108

merged 2 commits into from Feb 20, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 17, 2023

πŸ”— Linked issue

resolves #10844
#19078

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We have a tricky situation upcoming, with Node 16 due to be EOL on September 11th, 2023, but Nuxt 2 is not EOL until the end of the year.

Webpack 4 hard-codes md4 algorithm in several places in the code base meaning our options to resolve this for Nuxt 2 users are somewhat limited. In build/dev mode, this change monkey patches the crypto.createHash function if running on Node > 16 to upgrade md4 to md5. Would welcome other ideas too πŸ™

Warning
This should not be taken for an endorsement of continuing to run with Webpack 4, which is out of date and has a number of dependencies with issues. I expect that number to continue to grow, and we will not be able to resolve all of them. I would strongly urge migrating to Nuxt 3 if possible and the team will do our best to make this possible over the course of the year ❀️

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 17, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codecov-commenter
Copy link

Codecov Report

Base: 66.25% // Head: 66.18% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (55437ae) compared to base (fcc999d).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x   #19108      +/-   ##
==========================================
- Coverage   66.25%   66.18%   -0.08%     
==========================================
  Files          93       93              
  Lines        4090     4096       +6     
  Branches     1156     1158       +2     
==========================================
+ Hits         2710     2711       +1     
- Misses       1115     1119       +4     
- Partials      265      266       +1     
Flag Coverage Ξ”
unittests 66.18% <16.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/config/src/options.js 92.94% <16.66%> (-1.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

crookedneighbor added a commit to SpaceCowMedia/commander-spellbook-site that referenced this pull request Feb 19, 2023
Something is going wrong with Nuxt and Node 18. 

See nuxt/nuxt#19108 and nuxt/nuxt#10844
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (i hope not introducing side-effects, but seems won't!)

@danielroe danielroe merged commit 2c6b593 into 2.x Feb 20, 2023
@danielroe danielroe deleted the fix/webpack-md4 branch February 20, 2023 20:28
@danielroe danielroe mentioned this pull request Mar 1, 2023
nickgal added a commit to Wld-Doc/wld-doc.github.io that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants